Abdou Seck
f2ad3a6a0b
Merge pull request #697 from WowSuchRicky/main
...
Rename 'Lichi' to 'Lychee' in the fruit example
2021-04-13 10:40:07 -04:00
Abdou Seck
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming
...
Update collections exercises naming
2021-04-13 10:39:18 -04:00
WowSuchRicky
b790bafc02
Rename lichi to lychee in the fruit example
2021-04-09 14:08:02 -07:00
Taylor Yu
c3e7b83178
fix: use trait objects for from_str
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.
2021-04-04 18:56:10 -05:00
Taylor Yu
2e93a588e0
fix: use trait objects for try_from_into
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors. In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
2021-04-04 12:41:32 -05:00
Ignacio Le Fluk
a6509cc4d5
fix(functions3): improve function argument type ( #687 )
2021-04-04 09:43:25 +02:00
Rod Elias
3df094713f
chore: capitalize c
letter
...
By capitalizing the `c` letter it makes clear that we're talking about the C programming language.
2021-03-20 21:12:49 +01:00
Mickael Fortunato
ab9995e76e
doc: Update collections exercises instruction to match the standard naming
2021-03-18 19:11:15 +01:00
Mickael Fortunato
bef39b1259
fix(collections): Naming exercises for vectors and hashmap
2021-03-18 19:11:04 +01:00
Pascal H
0d894e6ff7
fix(quiz3): Force an answer to Q2 ( #672 )
...
Add also an example of unimplemented!() macro.
2021-03-16 10:14:25 +01:00
Pascal H
3bce2ef8d6
chore: clarify collections documentation
...
C++ `map` is more like BTreeMap.
`unordered_map` in C++(11) is the equivalent of `HashMap` in Rust.
(+ additional like for references).
2021-03-15 09:14:12 +01:00
Darius Wiles
9f3e8c2dde
fix(structs3): reword heading comment ( #664 )
2021-03-13 12:14:02 +01:00
cadolphs
05a753fe63
fix: add check to prevent naive implementation of is_international
...
* fix(structs3): Add check to prevent naive implementation
* chore(structs3): Add a missed newline after the test I added
2021-03-12 18:36:35 +01:00
Jirka Kremser
5f7c89f85d
fix(from_str): Correct typos
...
typos in the comments
2021-02-21 21:50:17 +01:00
apogeeoak
c6712dfccd
fix(iterators3): Enabled iterators3.rs to run without commented out tests.
2021-02-12 15:36:53 -05:00
apogeeoak
baf4ba175b
fix(iterators2): Moved errors out of tests.
...
Closes #359
2021-02-11 21:24:32 -05:00
apogeeoak
b29ea17ea9
feat: Added iterators5.rs exercise.
2021-02-10 18:03:29 -05:00
Tal
cc266d7d80
fix(move_semantics4): Remove redundant "instead" ( #640 )
2021-02-07 12:22:13 +01:00
Jean-Francois Chevrette
15e71535f3
fix(from_str): test for error instead of unwrap/should_panic
2021-01-21 07:55:22 -05:00
Sang-Heon Jeon
4f1374a6e7
feat(from_into) : add test for checking unnecessary trailing value
2021-01-09 00:08:38 +09:00
Sang-Heon Jeon
5a0521e92c
feat(from_str) : add test for checking unnecessary trailing value
2021-01-09 00:07:13 +09:00
Christian Zeller
7857b0a689
fix(threads1): line number correction
2021-01-06 13:47:20 +01:00
Marius Ungureanu
10965920fb
fix(move_semantics4): Small readbility improvement ( #617 )
...
* Small readbility improvement move_semantics4 doc
* Remove `an` as it refers to the argument
2021-01-06 10:12:33 +01:00
Axel Viala
0ef95947cc
fix(functions2): Change signature to trigger precise error message: ( #605 )
...
Now trigger this error:
```
error: expected type, found `)`
--> exercises/functions/functions2.rs:10:16
|
10 | fn call_me(num:) {
| ^ expected type
```
2020-12-27 12:36:38 +01:00
seancad
bcf14cf677
fix: update structs README
2020-12-15 08:32:46 +01:00
JuliaCao
90cfb6ff28
fix: added missing exercises to info.toml
2020-12-12 10:34:59 -08:00
Peter N
30644c9a06
fix: gives a bit more context to magic number
2020-12-08 10:08:25 +01:00
JuliaCao
033bf1198f
feat: match exercise order to book chapters ( #541 )
...
Added exercise to book chapter mapping table to exercise README
2020-12-07 15:37:19 +01:00
fmoko
cdc7d92e57
Merge pull request #592 from tinkhauser/vec1_bugfix
...
fix(vec1): Have test compare every element in a and v
2020-12-06 15:09:45 +01:00
Christos Kontas
04f1d079aa
feat(try_from_into): remove duplicate annotation
2020-12-03 17:51:30 +01:00
Jacob Tinkhauser
9b6c629397
fix(vec1): Have test compare every element in a and v
...
The previous test would stop comparing elements in array a and vec v upon reaching the last element of either. This resulted in the test passing even if v did not contain all the elements in a. This change to the test fixes that bug and should only pass if all the elements in a and v are present and equal.
2020-11-29 01:35:14 +00:00
Wei Hu
4f4cfcf3c3
fix(try_from_into): type error
2020-11-11 21:02:00 -08:00
JP
96347df9df
fix(try_from_into): Update description ( #584 )
...
Description update
2020-11-08 19:30:40 +01:00
fiplox
95ccd92616
feat(try_from_into): Add tests ( #571 )
...
Co-authored-by: Volodymyr Patuta <6977238-fiplox@users.noreply.gitlab.com>
2020-11-07 14:01:39 +01:00
JP
197d3a3d89
fix(iterators2): Update description ( #578 )
...
grammar fix in the description
2020-11-07 13:54:14 +01:00
sazid
633c00cf80
feat: Add HashMap exercises
2020-10-31 01:11:04 +06:00
sazid
0c12fa31c5
feat: Add Vec exercises
2020-10-31 01:10:49 +06:00
Matthew Smillie
472d8592d6
fix(primitive_types6): remove 'unused doc comment' warning
2020-10-13 23:20:17 -07:00
Matthew Smillie
4fb230daf1
fix(primitive_types6): missing comma in test
2020-10-13 23:18:41 -07:00
Axel Viala
2b1fb2b739
feat(primitive_types6): Add a test ( #548 )
...
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com>
Co-authored-by: fmoko <mokou@posteo.de>
2020-10-10 16:04:19 +02:00
Ryan McQuen
18e0bfef1d
fix(quiz3): Second test is for odd numbers, not even. ( #553 )
2020-10-10 13:11:57 +02:00
fmoko
69fc9ce10e
Merge pull request #545 from YJDoc2/main
2020-10-01 12:17:05 +02:00
Yashodhan Joshi
2ec0bdfd99
fix(variables5) : make shadowing more prominent
...
closes #375
2020-10-01 08:31:42 +05:30
fmoko
2a682abeef
Merge pull request #522 from calvinbrown085/adding-test-for-false-case
2020-09-27 17:05:42 +02:00
Greg Leonard
2933f51949
chore: Change point to comma in from_into.rs
...
A typo in the fn test_bad_age() hint message had a point rather than comma
Prev:
// Test that "Mark.twenty"
Current:
// Test that "Mark,twenty"
2020-09-25 13:39:52 +02:00
Calvin Brown
bec97b6c76
Fixing test3 to have enough tests to make sure we test all cases
2020-09-21 15:23:19 -05:00
Jannek Squar
114b54cbdb
fix(structs3): Small adjustment of variable name
...
Co-authored-by: Jannek <squar@informatik.uni-hamburg.de>
2020-09-19 21:22:56 +02:00
fmoko
0f16463794
Merge pull request #489 from mukundbhudia/iterators1
2020-09-18 15:23:28 +02:00
Ryan McQuen
3286c5ec19
fix(using_as): Add test so that proper type is returned. ( #512 )
2020-09-07 19:09:27 +02:00
Koalab99
ee7cdc66b3
chore: Removed extra whitespaces
...
Co-authored-by: Corentin ARNOULD <corentin.arn@gmail.com>
2020-08-27 19:51:19 +02:00
Samuel Batista
6bb0b48b10
Make macros4 not compile by default
...
Did you mean this? I'm new to rust and this test passed right away, so unsure what the intention was.
2020-08-26 22:17:03 -04:00
Antoine Barthelemy
101072ab9f
fix(exercises): adding question mark to quiz2
...
Question marks added for consistency.
closes #496
2020-08-25 16:38:41 +02:00
John Heath
dd54ccf677
Make comments on example clearer
...
I actually struggled because I overlooked the fact that I needed to change the 2.1 to "A+".
So I wanted to make things clearer for future rustlings.
2020-08-24 22:37:31 +01:00
seeplusplus
b4062ef699
fix(arc1): index mod should equal thread count
2020-08-16 20:55:50 -04:00
Étienne Barrié
3144d3ae63
chore: Run rustfmt on exercises
2020-08-10 10:24:21 -04:00
Mukund Bhudia
9642f5a3f6
feat: Added iterators1.rs exercise
2020-08-04 12:57:01 +01:00
Chad Dougherty
523d18b873
feat(try_from_into): Add insufficient length test ( #469 )
2020-07-13 11:39:05 +02:00
Benjamin Jones
bb5f404e35
chore: Alter whitespace for consistency
...
* Add newline after "I AM DONE" in exercises for consistency
* Remove trailing whitespace from exercises
2020-07-11 11:50:54 -07:00
DEWA Kazuyuki/出羽和之
4b6540c71a
fix(enums3): Update Message::ChangeColor to take a tuple. ( #457 )
2020-07-08 11:56:43 +02:00
fmoko
75c0053bb1
Merge pull request #433 from SebastienCaunes/fix#432
...
fix : Use of integer for prices, therefore also for weight
2020-06-22 00:09:09 +02:00
Alexx Roche
113cdae2d4
fix(arc1): Passively introduce attributes ( #429 )
...
Ensure that std::sync::Arc is actually used, as this exercise can be compiled using things already learnt in previous exercises.
2020-06-14 12:15:35 +02:00
Sebastien Caunes
9ca08b8f2b
fix : Use of integer for prices, therefore also for weight
...
rename confusing "from" and "to" to sender_country and recipient_country as suggested
2020-06-11 11:44:47 -05:00
millefalcon
307252e9ae
Added example to show the AsRef working
2020-06-08 07:51:34 -04:00
Alexx Roche
bb2ca25110
fix(box1): fix comment typo ( #426 )
...
Doesn't effect the code.
2020-06-06 12:07:39 +02:00
Alexx Roche
5563adbb89
fix: fix quiz naming inconsistency ( #421 )
...
Inconsistent naming when compared with the other quiz files.
2020-06-03 20:06:35 +02:00
Alexx Roche
524e17df10
fix(variables6): minor typo ( #419 )
...
Looks like this was cloned from variables5.rs
2020-06-03 13:34:43 +02:00
fmoko
73e848e96f
Merge pull request #416 from danwilhelm/traits-readme
...
feat: Add traits README
2020-05-30 17:58:31 +02:00
fmoko
5f0806967c
Merge pull request #409 from AlexandruGG/feature/box-exercise
2020-05-30 17:58:16 +02:00
Dan Wilhelm
173bb14140
feat: Add traits README
2020-05-28 20:21:33 -07:00
fmoko
918f310674
Merge pull request #410 from tsauvajon/fix-option1
...
fix(option1): Don't add only zeros to the numbers array
2020-05-29 00:33:00 +02:00
Dan Wilhelm
0311c03735
chore: Limit generics3 lines to 90 chars
2020-05-27 23:39:11 -07:00
AlexandruGG
df81141d6f
Address PR feedback: add tests
2020-05-27 10:03:59 +01:00
Thomas Sauvajon
cce6a44277
fix(option1): Don't add only zeros to the numbers array
2020-05-27 18:55:12 +10:00
AlexandruGG
7479a4737b
feat: Add box1.rs exercise
2020-05-26 21:46:24 +01:00
Evan Carroll
06ef4cc654
fix: confine the user further in variable exercises
...
We want to teach a specific lesson. To ensure that we do, let's try to
provide more clarity on what the user should not do.
2020-05-25 10:09:11 +02:00
Jade McGough
c7c3130507
chore: remove struct2 hint comment
2020-05-20 08:31:28 +02:00
Sanjay K
010a045692
feat: renames test to quiz, fixes #244
...
BREAKING CHANGE
* changed test to quiz: fixes issues in #244
* fixed info.toml: #244
* fixed naming related issues
2020-05-19 18:47:44 +02:00
fmoko
51666609f1
Merge pull request #365 from sjmann/generics-2-fix
2020-05-19 17:49:55 +02:00
Stefan Kupresak
10967bce57
fix(option2): Add TODO to comments ( #400 )
2020-05-16 22:48:18 +02:00
IkaR49
763aa6e378
feat: Rewrite try_from_into ( #393 )
2020-05-15 23:02:57 +02:00
Gaurang Tandon
d6c0a688e6
fix(test2): name of type String and &str ( #394 )
2020-05-13 12:38:14 +02:00
Evan Carroll
2b20c8a0f5
fix(errorsn): Try harder to confine the user. ( #388 )
2020-05-06 21:12:15 +02:00
Siobhan Jacobson
09e89bbcd3
Update Message::Move in the enums3 test to take a Point.
2020-05-04 18:59:23 -04:00
fmoko
7c4b1f910c
Merge pull request #372 from DiD92/exercise_structs3
2020-05-03 19:44:26 +02:00
fmoko
3ceabe91f8
Merge pull request #383 from wrobstory/wrobstory-exercises
2020-05-03 19:44:08 +02:00
fmoko
a39ffb2fb8
Merge pull request #368 from apatniv/update_test_case
2020-05-03 13:31:46 +02:00
apatniv
41f989135d
Review Comments: Add other test cases
2020-05-02 20:41:11 -04:00
Rob Story
f6cffc7e48
fix(option1): Add cast to usize, as it is confusing in the context of an exercise about Option
2020-05-02 16:39:37 -07:00
Rob Story
1da84b5f7c
feat: Add if2 exercise
2020-05-02 13:02:16 -07:00
Christofer Bertonha
c301814d68
chore: Remove deprecated description from error_handling/errorsn.rs
2020-05-02 18:30:11 +02:00
Jihchi Lee
a901499ede
fix(from_into.rs): typo
2020-04-30 15:53:50 +02:00
Dan Wilhelm
9590082848
fix: update iterator and macro text for typos and clarity
...
- /macros/README.md: Typo "modules" => "macros"
- iterators2.py: Reduce line length to <90-char width.
- iterators4.py: Update 'fun' => 'challenge' as per PR#177
- rustlings hint iterators4: improve clarity
2020-04-29 19:11:54 -07:00
Dídac Sementé Fernández
b66e2e0962
feat: Added exercise structs3.rs
2020-04-27 20:26:34 +02:00
apatniv
19fb1c240c
test: Add missing test case for from_str exercise
2020-04-21 22:51:56 -04:00
Steven Mann
630ff0e00b
chore: add explanatory comment to clippy1
2020-04-21 18:50:00 +02:00
sjmann
964c974a02
fix: update generics2 closes #362
2020-04-21 13:34:25 +01:00
lebedevsergey
c9e4f2cfb4
fix: confusing comment in conversions/try_from_into.rs
...
Co-authored-by: Lebedev <sergey.lebedev@corp.mail.ru>
2020-04-17 15:43:01 +02:00
Ufuk Celebi
6c3cc2caf5
chore: delete orphaned error_handling/option1.rs
...
`error_handling/option1.rs` has been replaced by `option/option1.rs` and
is not referenced in `info.toml` any more.
2020-04-15 23:52:31 +02:00
Said Aspen
5999acd24a
feat: Add exercise variables6 covering const ( #352 )
2020-04-14 10:13:20 +02:00
fmoko
052f0aa7d4
Merge pull request #292 from Tuxified/patch-1
...
Remove duplicate not done comment
2020-04-08 11:23:49 +02:00
Tonći Galić
60393999b8
remove bottom comment instead of top
2020-04-08 11:00:11 +02:00
Roberto Vidal
b3a3351e8e
fix: revert primitive_types4 ( #296 )
2020-04-08 10:42:35 +02:00
Sanjay K
86b5c08b9b
feat: Add Option2 exercise ( #290 )
...
* added option2
* changed up the exercise, modified the help section
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
Co-authored-by: fmoko <mokou@posteo.net>
2020-04-07 20:16:10 +02:00
Tonći Galić
dab90f7b91
Remove duplicate not done comment
...
As indicated in #259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from #281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
2020-04-07 17:00:45 +02:00
Roberto Vidal
3b6d5c3aaa
feature: makes "compile" exercise print output, resolves #270
...
When running "compile"-mode exercises in interactive `verify` mode,
we print their output when we prompt the learner if they want to
continue. This improves the "experimentation" experience, since
trying different things does produce a visible change.
2020-04-06 16:17:14 +02:00
fmoko
7ce42941ea
Merge pull request #282 from sanjaykdragon/master
...
feat: added option exercise
2020-04-05 15:58:09 +02:00
fmoko
b135b589e0
Merge pull request #280 from sjmann/generics-exercises
...
feat: added generics exercises
2020-04-05 14:40:34 +02:00
Sanjay K
05ca3d77f7
Merge branch 'master' of https://github.com/sanjaykdragon/rustlings
2020-04-02 08:41:14 -04:00
Sanjay K
6deee7e3e9
fixed spacing
2020-04-02 08:40:59 -04:00
Sanjay K
9788496a85
Update option1.rs
2020-03-11 13:44:41 -04:00
Sanjay K
6d3a412d47
Update option1.rs
2020-03-11 13:44:10 -04:00
skim
bc22ec382f
adds additional test to meet exercise rules
2020-03-11 07:58:04 -07:00
Sanjay K
135e5d47a7
feat: added excercise for option
2020-03-05 15:52:54 -05:00
sjmann
0f8001ea44
add I AM NOT DONE comments
2020-02-28 00:31:55 +00:00
sjmann
29b30ec946
Merge branch 'master' of https://github.com/sjmann/rustlings into generics-exercises
2020-02-28 00:19:45 +00:00
sjmann
76be5e4e99
feat: added new exercises for generics
2020-02-28 00:09:08 +00:00
Mario Reder
1e2fd9c92f
feat: Add clippy lints
...
- adds a new 'clippy' category for exercises
- clippy exercises should throw no warnings
- install script now also installs clippy
is related to https://github.com/rust-lang/rust-clippy/issues/2604
2020-02-26 14:07:07 +01:00
bors
78295ce92f
Auto merge of #274 - sjmann:master, r=fmoko
...
chore: fixed merge conflicts from traits exercises added by s-marios
I hope this doesn't step on any toes but I wanted to try the traits exercises from #216 so I updated them to match the new structure with hints included in info.toml
2020-02-25 21:27:39 +00:00
Stig Johan Berggren
a45486f2d0
Add a second test case
2020-02-25 14:25:03 +01:00
Stig Johan Berggren
8b971ffab6
Enable test for exercise test4
2020-02-25 14:13:10 +01:00
Steven Mann
dc84aacc65
remove confusing comment wording
2020-02-25 11:00:09 +00:00
sjmann
b559cdd73f
added traits exercises
2020-02-25 09:48:50 +00:00
sjmann
a3f70124dc
fixed typo
2020-02-22 14:28:07 +00:00
sjmann
bec8e3a644
reworded missing exercise explanation
2020-02-22 13:04:37 +00:00
Jason Tsai
39fa7ae8b7
chore: Correct test command in tests1.rs comment
2020-01-29 13:48:43 +08:00
Paul Bissex
ade52ffb73
Fixed mangled sentence from book; edited for clarity
2020-01-25 03:24:14 -05:00
Torben Jonas
0c73609e6f
feat: Add variables5.rs exercise
...
closes #260
2020-01-14 21:10:07 +01:00
gnodarse
fd57f8f2c1
Created consistent money unit
2019-12-29 19:15:32 -05:00
dmitri-mamrukov
dfdf8093eb
Enable a test and improve per clippy's suggestion.
2019-12-23 21:37:09 -05:00
Abdou Seck
fc26b5e151
I AM NOT DONE comment in conversions exercise files
2019-12-16 11:33:00 -05:00
Abdou Seck
0c85dc1193
feat: Add type conversion and parsing exercises
2019-12-16 09:12:13 -05:00
marisa
fe10e06c37
fix(tests1): Change test command
...
Closes #243 .
2019-12-16 13:05:25 +01:00
Rahat Ahmed
54571a5fca
fix(iterators2): Remove reference to missing iterators2.rs
2019-12-07 23:25:13 -08:00
Jens
31c25ebb50
Add link to chapter on pattern syntax
...
After being stuck on exercise enums3.rs for about an hour or two, having read the entire chapter on enums 2-3 times, and still being unable to complete the exercise, i started broadening my reading. I finally found the answer in the rust docs via google.
2019-11-24 09:28:33 +01:00
Roberto Vidal
b565c4d3e7
fix: line numbers in several exercises and hints
...
The introduction of `I AM NOT DONE` shifted the lines of all
exercises, which now need adjustment.
2019-11-14 08:21:56 +01:00
Chris Keschnat
c42c3b2101
fix(arc1): Fix some words in the comment
2019-11-12 18:37:23 +01:00
Chris Keschnat
fda5a47069
fix(variables1): Correct wrong word in comment
2019-11-12 17:33:25 +01:00
Roberto Vidal
ded2c034ba
fix(primitive_types4): update outdated comment
2019-11-12 12:52:28 +01:00
marisa
1a7bb5a400
Address feedback
2019-11-11 17:47:45 +01:00
marisa
ec2d4bd3ee
Merge branch 'master' into refactor-hints
2019-11-11 17:21:06 +01:00
marisa
9bdb0a12e4
feat: Refactor hint system
...
Hints are now accessible using the CLI subcommand `rustlings hint
<exercise name`.
BREAKING CHANGE: This fundamentally changes the way people interact with exercises.
2019-11-11 16:51:38 +01:00
Roberto Vidal
2cdd61294f
feat: improve watch
execution mode
...
The `watch` command now requires user action to move to the next
exercise.
BREAKING CHANGE: this changes the behavior of `watch`.
2019-11-11 16:23:35 +01:00
marisa
f72e5a8f05
fix(structs1): Remove misleading comment
2019-11-11 13:57:59 +01:00
marisa
6dcecb38a4
fix(strings): Move Strings before Structs
...
Closes #204 .
2019-11-11 13:46:42 +01:00
marisa
dcfb427b09
fix(errors3): Update hint
...
Closes #185 .
2019-11-11 13:37:43 +01:00
marisa
ad03d180c9
fix(if1): Remove return
reference
...
This closes #153 .
2019-11-11 13:34:21 +01:00
bors
c6dad28ddc
Auto merge of #224 - nyxtom:feat-enums, r=fmoko
...
feat: Add enums exercises
Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
2019-11-09 09:41:36 +00:00
marisa
79a569422c
fix: Rewrite test1 logic
2019-10-29 20:53:41 +01:00
Thomas Holloway
dc15032112
feat: Add enums exercises
2019-10-28 22:49:49 -05:00
Scott Sweeny
2821227acf
chore: Clarify comment in exercises/test1.rs
...
closes #194
The author of issue #194 suggests that the wording of the comment is at
least ambiguous about the desired results. I believe this change more
clearly describes the expectation of the exercise.
2019-10-28 23:08:46 -04:00