Shao Yang Hong
6bd791f2f4
fix(structs): Add 5.3 to structs/README ( #652 )
...
Co-authored-by: Shao Yang Hong <shaoyang.hong@ninjavan.co>
2021-04-20 11:19:24 +02:00
k12ish
b4de659438
fix(option2): Rename uninformative variables ( #675 )
...
Renaming uninformative names like `optional_value`, `value`, `optional_values_vec` and `value` helps users distinguish between the two parts of the task.
2021-04-20 11:18:05 +02:00
Pete Pavlovski
72aaa15e6a
fix(hashmap2): Update incorrect assertion ( #660 )
...
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :)
A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
2021-04-20 11:15:49 +02:00
Abdou Seck
f2ad3a6a0b
Merge pull request #697 from WowSuchRicky/main
...
Rename 'Lichi' to 'Lychee' in the fruit example
2021-04-13 10:40:07 -04:00
Abdou Seck
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming
...
Update collections exercises naming
2021-04-13 10:39:18 -04:00
WowSuchRicky
b790bafc02
Rename lichi to lychee in the fruit example
2021-04-09 14:08:02 -07:00
Taylor Yu
c3e7b83178
fix: use trait objects for from_str
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.
2021-04-04 18:56:10 -05:00
Taylor Yu
2e93a588e0
fix: use trait objects for try_from_into
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors. In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
2021-04-04 12:41:32 -05:00
Ignacio Le Fluk
a6509cc4d5
fix(functions3): improve function argument type ( #687 )
2021-04-04 09:43:25 +02:00
Rod Elias
3df094713f
chore: capitalize c
letter
...
By capitalizing the `c` letter it makes clear that we're talking about the C programming language.
2021-03-20 21:12:49 +01:00
Mickael Fortunato
ab9995e76e
doc: Update collections exercises instruction to match the standard naming
2021-03-18 19:11:15 +01:00
Mickael Fortunato
bef39b1259
fix(collections): Naming exercises for vectors and hashmap
2021-03-18 19:11:04 +01:00
Pascal H
0d894e6ff7
fix(quiz3): Force an answer to Q2 ( #672 )
...
Add also an example of unimplemented!() macro.
2021-03-16 10:14:25 +01:00
Pascal H
3bce2ef8d6
chore: clarify collections documentation
...
C++ `map` is more like BTreeMap.
`unordered_map` in C++(11) is the equivalent of `HashMap` in Rust.
(+ additional like for references).
2021-03-15 09:14:12 +01:00
Darius Wiles
9f3e8c2dde
fix(structs3): reword heading comment ( #664 )
2021-03-13 12:14:02 +01:00
cadolphs
05a753fe63
fix: add check to prevent naive implementation of is_international
...
* fix(structs3): Add check to prevent naive implementation
* chore(structs3): Add a missed newline after the test I added
2021-03-12 18:36:35 +01:00
Jirka Kremser
5f7c89f85d
fix(from_str): Correct typos
...
typos in the comments
2021-02-21 21:50:17 +01:00
Tal
cc266d7d80
fix(move_semantics4): Remove redundant "instead" ( #640 )
2021-02-07 12:22:13 +01:00
Jean-Francois Chevrette
15e71535f3
fix(from_str): test for error instead of unwrap/should_panic
2021-01-21 07:55:22 -05:00
Sang-Heon Jeon
4f1374a6e7
feat(from_into) : add test for checking unnecessary trailing value
2021-01-09 00:08:38 +09:00
Sang-Heon Jeon
5a0521e92c
feat(from_str) : add test for checking unnecessary trailing value
2021-01-09 00:07:13 +09:00
Christian Zeller
7857b0a689
fix(threads1): line number correction
2021-01-06 13:47:20 +01:00
Marius Ungureanu
10965920fb
fix(move_semantics4): Small readbility improvement ( #617 )
...
* Small readbility improvement move_semantics4 doc
* Remove `an` as it refers to the argument
2021-01-06 10:12:33 +01:00
Axel Viala
0ef95947cc
fix(functions2): Change signature to trigger precise error message: ( #605 )
...
Now trigger this error:
```
error: expected type, found `)`
--> exercises/functions/functions2.rs:10:16
|
10 | fn call_me(num:) {
| ^ expected type
```
2020-12-27 12:36:38 +01:00
seancad
bcf14cf677
fix: update structs README
2020-12-15 08:32:46 +01:00
JuliaCao
90cfb6ff28
fix: added missing exercises to info.toml
2020-12-12 10:34:59 -08:00
Peter N
30644c9a06
fix: gives a bit more context to magic number
2020-12-08 10:08:25 +01:00
JuliaCao
033bf1198f
feat: match exercise order to book chapters ( #541 )
...
Added exercise to book chapter mapping table to exercise README
2020-12-07 15:37:19 +01:00
fmoko
cdc7d92e57
Merge pull request #592 from tinkhauser/vec1_bugfix
...
fix(vec1): Have test compare every element in a and v
2020-12-06 15:09:45 +01:00
Christos Kontas
04f1d079aa
feat(try_from_into): remove duplicate annotation
2020-12-03 17:51:30 +01:00
Jacob Tinkhauser
9b6c629397
fix(vec1): Have test compare every element in a and v
...
The previous test would stop comparing elements in array a and vec v upon reaching the last element of either. This resulted in the test passing even if v did not contain all the elements in a. This change to the test fixes that bug and should only pass if all the elements in a and v are present and equal.
2020-11-29 01:35:14 +00:00
Wei Hu
4f4cfcf3c3
fix(try_from_into): type error
2020-11-11 21:02:00 -08:00
JP
96347df9df
fix(try_from_into): Update description ( #584 )
...
Description update
2020-11-08 19:30:40 +01:00
fiplox
95ccd92616
feat(try_from_into): Add tests ( #571 )
...
Co-authored-by: Volodymyr Patuta <6977238-fiplox@users.noreply.gitlab.com>
2020-11-07 14:01:39 +01:00
JP
197d3a3d89
fix(iterators2): Update description ( #578 )
...
grammar fix in the description
2020-11-07 13:54:14 +01:00
sazid
633c00cf80
feat: Add HashMap exercises
2020-10-31 01:11:04 +06:00
sazid
0c12fa31c5
feat: Add Vec exercises
2020-10-31 01:10:49 +06:00
Matthew Smillie
472d8592d6
fix(primitive_types6): remove 'unused doc comment' warning
2020-10-13 23:20:17 -07:00
Matthew Smillie
4fb230daf1
fix(primitive_types6): missing comma in test
2020-10-13 23:18:41 -07:00
Axel Viala
2b1fb2b739
feat(primitive_types6): Add a test ( #548 )
...
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com>
Co-authored-by: fmoko <mokou@posteo.de>
2020-10-10 16:04:19 +02:00
Ryan McQuen
18e0bfef1d
fix(quiz3): Second test is for odd numbers, not even. ( #553 )
2020-10-10 13:11:57 +02:00
fmoko
69fc9ce10e
Merge pull request #545 from YJDoc2/main
2020-10-01 12:17:05 +02:00
Yashodhan Joshi
2ec0bdfd99
fix(variables5) : make shadowing more prominent
...
closes #375
2020-10-01 08:31:42 +05:30
fmoko
2a682abeef
Merge pull request #522 from calvinbrown085/adding-test-for-false-case
2020-09-27 17:05:42 +02:00
Greg Leonard
2933f51949
chore: Change point to comma in from_into.rs
...
A typo in the fn test_bad_age() hint message had a point rather than comma
Prev:
// Test that "Mark.twenty"
Current:
// Test that "Mark,twenty"
2020-09-25 13:39:52 +02:00
Calvin Brown
bec97b6c76
Fixing test3 to have enough tests to make sure we test all cases
2020-09-21 15:23:19 -05:00
Jannek Squar
114b54cbdb
fix(structs3): Small adjustment of variable name
...
Co-authored-by: Jannek <squar@informatik.uni-hamburg.de>
2020-09-19 21:22:56 +02:00
fmoko
0f16463794
Merge pull request #489 from mukundbhudia/iterators1
2020-09-18 15:23:28 +02:00
Ryan McQuen
3286c5ec19
fix(using_as): Add test so that proper type is returned. ( #512 )
2020-09-07 19:09:27 +02:00
Koalab99
ee7cdc66b3
chore: Removed extra whitespaces
...
Co-authored-by: Corentin ARNOULD <corentin.arn@gmail.com>
2020-08-27 19:51:19 +02:00